Skip to content

build: update release cadence - #89

Merged
hallvictoria merged 14 commits into
mainfrom
hallvictoria/release-on-merge
Jul 28, 2026
Merged

build: update release cadence#89
hallvictoria merged 14 commits into
mainfrom
hallvictoria/release-on-merge

Conversation

@hallvictoria

@hallvictoria hallvictoria commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Purpose

  • Release on changes to src/
    • Only release for functionality changes - not on updates to documentation or pipeline
    • Ignore __init__.py updates - prevent circular releases
    • Auto-updates the version to + b (n+1). Auto-triggered releases only support releasing beta version. Major / minor updates must be done manually.
  • Minor default value updates
  • Address minor comments from previous PR

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone https://github.com/Azure/azure-functions-agents-runtime.git
cd azure-functions-agents-runtime
git checkout [branch-name]
pip install -e .
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@hallvictoria
hallvictoria marked this pull request as ready for review July 10, 2026 18:35
@hallvictoria
hallvictoria requested a review from a team as a code owner July 10, 2026 18:35

@larohra Laveesh Rohra (larohra) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Overall this is a reasonable release-cadence update, but the config-docs auto-generation piece has one critical dead-code bug that should be fixed before merge:

🔴 Critical

  • generate_config_reference.py imports new *_DESCRIPTIONS dicts from schema.py, but they're immediately shadowed by pre-existing local dict literals later in the same file — the import has zero effect on generated docs (verified empirically with a marker-string test). See inline comment for details and the fix path.

🟡 Suggestions

  • The new schema.py description dicts are also stale/incomplete relative to the local copies they're meant to replace (missing web_request/workflows entries) — worth reconciling now while fresh, since it'll block the eventual cleanup of the dead local dicts.
  • docs/AUTO_GENERATION.md now tells contributors to edit schema.py for descriptions, which is misleading until the above is actually fixed.
  • versionPattern's default was narrowed to double-quotes-only, inconsistent with the template it calls (which still supports both quote styles) — likely fine today but worth confirming it's intentional.
  • Re: the cross-stage variable propagation (also flagged in the existing comment on the Build stage below) — it's not just boilerplate, build-artifacts.yml/publish-release.yml genuinely need libraryVersion before checkout. But ResolveVersion could be folded into BumpVersion's job as its first step, dropping one stage's pool spin-up and trimming the repeated stageDependencies blocks from 3 copies to 2. See inline comment for specifics.

🟢 Looks good

  • The new trigger/pr: none block is a well-justified fix for unwanted default-branch pipeline triggers.

Happy to help with the fix for the dead-code issue if useful.

Comment thread eng/scripts/generate_config_reference.py
Comment thread docs/AUTO_GENERATION.md
Comment thread src/azure_functions_agents/config/schema.py
Comment thread eng/ci/library-release.yml
Comment thread eng/ci/library-release.yml

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the release pipeline to auto-trigger releases on src/** changes and auto-compute the next beta version when libraryVersion isn’t provided, while also relocating doc-generation field description metadata from the generator script into schema.py (so the schema remains the source of truth for enhanced field descriptions).

Changes:

  • Add src/**-scoped pipeline trigger + a new ResolveVersion stage to compute the next x.y.zb(n+1) version when libraryVersion is empty.
  • Move *_DESCRIPTIONS / defaults dictionaries out of eng/scripts/generate_config_reference.py into src/azure_functions_agents/config/schema.py.
  • Update documentation/process guidance to reflect where field description metadata lives.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/azure_functions_agents/config/schema.py Adds doc-generation description/default dictionaries alongside the schema models.
eng/scripts/generate_config_reference.py Switches to reading description/default dictionaries from schema.py instead of defining them locally.
eng/ci/library-release.yml Adds src/** trigger scoping and a ResolveVersion stage; wires resolved version into bump/build/release stages.
docs/AUTO_GENERATION.md Updates guidance to edit enhanced field descriptions in schema.py.
.github/skills/add-feature/SKILL.md Broadens wording about which docs under docs/ may need updates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread eng/ci/library-release.yml
Comment thread src/azure_functions_agents/config/schema.py
@hallvictoria
hallvictoria merged commit 1858304 into main Jul 28, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants